replace vault to local by fackee · Pull Request #719 · dapr/java-sdk

fackee · 2022-03-30T02:30:08Z

Signed-off-by: zjx244729 zjx244729@alibaba-inc.com

Description

Replace the Secret Store from Hashicorp Vault to Local File

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #667

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

mukundansundar

@dntbeSris One change ... The vault install is removed from the validate.yaml file.
Because it was removed from build.yaml it is breaking the build.

mukundansundar · 2022-03-30T03:13:05Z

      run: |
        docker-compose -f ./sdk-tests/deploy/local-test-kafka.yml up -d
        docker ps
-    - name: Install Local Hashicorp Vault using docker-compose


have the vault install in the build.yaml and remove it from the validate.yaml file ....

ok, and the Integration Test is vault secret. should i fix it ?

Yes please @dntbeSris
cc @artursouza

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

…ava-sdk into issue_secret_example

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

…ava-sdk into issue_secret_example

mukundansundar

in the integration tests why have the secrets file be created on the file. I think the test local secrets file can be committed as a file in the components directory itself ...
This is currently causing an issue with other tests also since the component in being loaded in other tests also and it is not finding the secrets file which is only created on the fly for this test ... so dapr initialising is failing because the component is not being loaded ...

Changing it to a file that exists in the components directory from start is fine for integration tests ...

fackee · 2022-04-02T02:44:17Z

yep! i create and delete the secret file just in secret test program at first.but it made the other tests failed . because it always load all components . so i created the file earlier. this change in commit 9f21553

fackee · 2022-04-07T02:27:25Z

in the integration tests why have the secrets file be created on the file. I think the test local secrets file can be committed as a file in the components directory itself ... This is currently causing an issue with other tests also since the component in being loaded in other tests also and it is not finding the secrets file which is only created on the fly for this test ... so dapr initialising is failing because the component is not being loaded ...

Changing it to a file that exists in the components directory from start is fine for integration tests ...

what should i do next ？

codecov · 2022-04-20T14:20:45Z

Codecov Report

Merging #719 (0ec78cf) into master (81ebd76) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #719   +/-   ##
=========================================
  Coverage     78.19%   78.19%           
  Complexity     1117     1117           
=========================================
  Files            97       97           
  Lines          3417     3417           
  Branches        399      399           
=========================================
  Hits           2672     2672           
  Misses          547      547           
  Partials        198      198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65936ee...0ec78cf. Read the comment docs.

mukundansundar

lgtm. @artursouza Please review.

* replace vault to local Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * change secret store name style Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * delete vault token file Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * remove vault int validate.yml Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * fix it secret case Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * replace vault to local Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * change secret store name style Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * delete vault token file Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * remove vault int validate.yml Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * fix it secret case Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * fix it dead loop Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> Co-authored-by: zjx244729 <zjx244729@alibaba-inc.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* replace vault to local Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * change secret store name style Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * delete vault token file Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * remove vault int validate.yml Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * fix it secret case Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * replace vault to local Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * change secret store name style Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * delete vault token file Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * remove vault int validate.yml Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * fix it secret case Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> * fix it dead loop Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com> Co-authored-by: zjx244729 <zjx244729@alibaba-inc.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: naah69 <nayan3480232@163.com>

replace vault to local

4645590

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

fackee requested review from a team as code owners March 30, 2022 02:30

zjx244729 added 2 commits March 30, 2022 10:46

change secret store name style

7c789f8

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

delete vault token file

7bf5874

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

mukundansundar suggested changes Mar 30, 2022

View reviewed changes

zjx244729 added 7 commits March 30, 2022 11:45

remove vault int validate.yml

95819cb

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

fix it secret case

5c3aaf1

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

replace vault to local

dd20d1e

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

change secret store name style

e4fbe4d

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

delete vault token file

9b164f2

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

remove vault int validate.yml

f3cb68c

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

fix it secret case

0dc3c18

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

fackee force-pushed the issue_secret_example branch from 5c3aaf1 to 0dc3c18 Compare March 31, 2022 06:44

zjx244729 and others added 4 commits March 31, 2022 15:06

Merge branch 'issue_secret_example' of https://github.com/dntbeSris/j…

5276abb

…ava-sdk into issue_secret_example

Merge branch 'master' into issue_secret_example

e75cada

fix it dead loop

9f21553

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

Merge branch 'issue_secret_example' of https://github.com/dntbeSris/j…

b8576f7

…ava-sdk into issue_secret_example

mukundansundar suggested changes Apr 1, 2022

View reviewed changes

Merge branch 'master' into issue_secret_example

0ec78cf

mukundansundar approved these changes Apr 20, 2022

View reviewed changes

mukundansundar merged commit e2d4d1e into dapr:master May 5, 2022

yaron2 assigned fackee Jul 6, 2022

yaron2 added this to the v1.6 milestone Jul 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

replace vault to local#719

replace vault to local#719
mukundansundar merged 15 commits into
dapr:masterfrom
fackee:issue_secret_example

fackee commented Mar 30, 2022 •

edited

Loading

Uh oh!

mukundansundar left a comment

Uh oh!

mukundansundar Mar 30, 2022

Uh oh!

fackee Mar 30, 2022 •

edited

Loading

Uh oh!

mukundansundar Mar 30, 2022

Uh oh!

fackee Mar 31, 2022

Uh oh!

mukundansundar left a comment •

edited

Loading

Uh oh!

fackee commented Apr 2, 2022

Uh oh!

fackee commented Apr 7, 2022

Uh oh!

codecov Bot commented Apr 20, 2022

Uh oh!

mukundansundar left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

fackee commented Mar 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue reference

Checklist

Uh oh!

mukundansundar left a comment

Choose a reason for hiding this comment

Uh oh!

mukundansundar Mar 30, 2022

Choose a reason for hiding this comment

Uh oh!

fackee Mar 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mukundansundar Mar 30, 2022

Choose a reason for hiding this comment

Uh oh!

fackee Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

mukundansundar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fackee commented Apr 2, 2022

Uh oh!

fackee commented Apr 7, 2022

Uh oh!

codecov Bot commented Apr 20, 2022

Codecov Report

Uh oh!

mukundansundar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fackee commented Mar 30, 2022 •

edited

Loading

fackee Mar 30, 2022 •

edited

Loading

mukundansundar left a comment •

edited

Loading